Search handler and client with HTTP POST-based request serialization. #8892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
reviewed
Aug 14, 2025
| Future<shelf.Response> _debugHandler(shelf.Request request) async { | ||
| final info = await searchIndex.indexInfo(); | ||
| return debugResponse(info.toJson()); | ||
| } | ||
|
|
||
| /// Handles /search requests. | ||
| /// Handles GET /search requests. |
There was a problem hiding this comment.
This seems to contradict the code below that branches on the method....
There was a problem hiding this comment.
Updated comment, it should handle both.
sigurdm
reviewed
Aug 14, 2025
| @@ -53,7 +53,6 @@ enum SearchOrder { | |||
| /// WARNING: The value shouldn't be used anymore. | |||
| /// | |||
| /// TODO: remove in a future release. | |||
| @Deprecated('Popularity is no longer used.') | |||
| popularity, | |||
There was a problem hiding this comment.
Intentional, but more of a convenience: if we keep it, the generated code uses it and analyzer complains about using a deprecated field. I did not want to remove it yet, but maybe we should?
There was a problem hiding this comment.
Removed the field. I think we did have enough time since we have changed from popularity to downloads. Old bookmarks may break, but that is going to happen no matter when we remove it.
sigurdm
approved these changes
Aug 14, 2025
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TextMatchExtenttopkg/_pub_shared, and added the new data class there, as the build command's inclusion rules otherwise couldn't identify all the required types./search, since we have so little change based on the HTTP methodwithRetryHttpClientto reuse some of its logic